Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gameplay Stats Tweaks #2379

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Conversation

tcpowell
Copy link
Contributor

@tcpowell tcpowell commented Jan 22, 2023

Persist Gameplay Stats Across Sessions: Resolves #2144

Not sure if this is something that would need to be configurable or not. If so, it would be a trivial amount of effort to introduce a checkbox to decide whether or not to "remember" across sessions.

Also adds configuration to Gameplay Stats to show only Timestamps (for speedrunning), Counts, or Both.

Timestamps only:
gameplayStatsTimestamps

Counts only:
gameplayStatsCounts

Both:
gameplayStatsBoth

Build Artifacts

@tcpowell tcpowell changed the title Persist Gameplay Stats Across Sessions Gameplay Stats Tweaks Jan 22, 2023
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick suggestion, but otherwise looks good!

soh/soh/Enhancements/gameplaystats.cpp Outdated Show resolved Hide resolved
@briaguya-ai briaguya-ai merged commit ec4cee7 into HarbourMasters:develop Jan 25, 2023
@RenaKunisaki
Copy link

The timestamps get cut off if you're bad at the game and take 10+ hours.

@briaguya-ai
Copy link
Contributor

The timestamps get cut off if you're bad at the game and take 10+ hours.

could you make this into a separate issue? (ideally with a screenshot?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gameplay stats doesn't stay open between sessions
4 participants