Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWEAK: Controller Navigation rename + tooltip #2407

Merged
merged 6 commits into from
Jan 28, 2023

Conversation

PurpleHato
Copy link
Contributor

@PurpleHato PurpleHato commented Jan 26, 2023

Renamed the Controller Navigation to ImGui Controller Navigation
People were always confused by it and enabled it by thinking it was in-game related

Build Artifacts

soh/soh/GameMenuBar.cpp Outdated Show resolved Hide resolved
soh/soh/GameMenuBar.cpp Outdated Show resolved Hide resolved
@briaguya-ai
Copy link
Contributor

do people know what ImGui is? Maybe there's a better name we could use for this?

@PurpleHato
Copy link
Contributor Author

I do not think poeple know what ImGui is, but I think it will make less confusion than juste "Enable Controller Navigation" that sounds, more like a game thing

I'm open to ideas if needed

@aMannus
Copy link
Contributor

aMannus commented Jan 27, 2023

I think someone had the idea of Menubar Controller Navigation or something right?

@briaguya-ai
Copy link
Contributor

I think someone had the idea of Menubar Controller Navigation or something right?

Yes, @GreatArgorath suggested that (I like it!)

@PurpleHato
Copy link
Contributor Author

Tweaked :)
image

soh/soh/GameMenuBar.cpp Outdated Show resolved Hide resolved
soh/soh/GameMenuBar.cpp Outdated Show resolved Hide resolved
@briaguya-ai
Copy link
Contributor

@PurpleHato i removed "merge ready" so you can address @aMannus's comments

@PurpleHato
Copy link
Contributor Author

There we are :)
image

@briaguya-ai briaguya-ai merged commit f6c310a into HarbourMasters:develop Jan 28, 2023
@PurpleHato PurpleHato deleted the ControllerNav branch January 28, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants