-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude audio from shuffle #2411
exclude audio from shuffle #2411
Conversation
You also named the tab "Exclude Sequences From Shuffle" but in reality, you can also exclude sound effects in the tab, so the name isn't very accurate. Maybe "Exclude SFX when randomizing" is more accurate (albeit a bit long)? |
Maybe out of scope of this PR, but a button to remove all the exclusions at once could also be useful (and excluded locations in the Randomizer menu could also use this if we had it). This really is more of a suggestion though. |
@aMannus this is ready for another look
I don't like that because i think of SFX as sound effects, and separate from music. I ended up renaming the whole window the "Audio Editor" and changed the name of the tab from "Exclude Sequences From Shuffle" to "Audio Shuffle Pool Management" it's wordy and i'm not the biggest fan of the name but it at least feels accurate
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes look good! Definitely puts us in a place where we can better optimise audio editing down the line 👯
Left small comments here and there on things we could improve.
Co-authored-by: David Chavez <david@dcvz.io>
Co-authored-by: David Chavez <david@dcvz.io>
Co-authored-by: David Chavez <david@dcvz.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
todo:
future things (make issues for these when this gets merged):
Build Artifacts