Projectile ammo matches ItemAction instead of age #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extracted logic from months-old PR
This was referenced Feb 11, 2023
briaguya-ai
requested changes
Feb 14, 2023
Done. I had trouble choosing the correct submenu to put it under. I ended up putting it in "Enhancements -> Gameplay -> Items", but was also considering "Enhancements -> Fixes" |
briaguya-ai
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Part of an old PR I posted months ago. Figured a smaller PR per each 'feature' would be better for code review.
Makes slingshot shoot seeds, and bow shoot arrows for both ages. Made sure that the shooting gallery minigames gave the player the correct item for their age.
I don't know what the general policy about this kind of change is; whether it would be better to have it behind an enhancement/fix toggle or not.
Build Artifacts