Fix: Hyrule Field bridge entrance and sun song placing link out of bounds in Entrance Rando #2457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "castle guard exit market" enhancement places link at the "Near Drawbridge" entrance instead of the "From Drawbridge" entrance. This is so link does not fall into the water at night as a convenience.
In Overworld shuffle, the "Near Drawbridge" entrance was passed into the override entrance logic instead of "From Drawbridge" resulting in the the vanilla entrance being used. This fixes that to use the proper entrance to get the override value.
I also adjusted the spawn position for "From Drawbridge" for child at night in overworld shuffle to place link just past the bridge so that you also dont fall into the water when going through the normal entrance
It was also reported that if grotto shuffle is on, but warp song shuffle is off, if you leave a grotto -> play a warp song -> then play sun's song, the grotto's coordinates are used as links respawn value. I adjusted the warp song override logic to happen when ER is on in general, rather than only when warp song shuffle is on. This makes it so the ER state is aware that a warpsong was used and so sun song ignores the grotto respawn location.
I also update some scene magic numbers to use proper enums.
Fixes #2443
Build Artifacts