greg bridge in logic #2460
Merged
greg bridge in logic #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2023 21:34
Closed
garrettjoecox
approved these changes
Feb 17, 2023
dcvz
approved these changes
Feb 17, 2023
Archez
requested changes
Feb 17, 2023
There was a problem hiding this comment.
Just a quick suggestion.
Also there should be a hint registered in the hint table for GREG_RUPEE, otherwise the hint for Greg will be broken/crash.
Not sure if it should go in hint_list.cpp or hint_list_exclude_overworld.cpp, probably the overworld one.
Ah there is already a hint in the hint_list_items.cpp
| @@ -177,7 +177,7 @@ void ItemTable_Init() { // RandomizerGet | |||
| //Generic Items | |||
| itemTable[RECOVERY_HEART] = Item(RG_RECOVERY_HEART, Text{"Recovery Heart", "Coeur de Vie", "Corazón"}, ITEMTYPE_ITEM, GI_HEART, false, &noVariable, RECOVERY_HEART); | |||
| itemTable[GREEN_RUPEE] = Item(RG_GREEN_RUPEE, Text{"Green Rupee", "Rubis Vert", "Rupia verde"}, ITEMTYPE_ITEM, GI_RUPEE_GREEN, false, &noVariable, GREEN_RUPEE); | |||
| itemTable[GREG_RUPEE] = Item(RG_GREG_RUPEE, Text{"Greg Rupee", "Rubis Greg", "Rupia Greg"}, ITEMTYPE_ITEM, GI_RUPEE_GREEN, false, &noVariable, GREG_RUPEE); | |||
| itemTable[GREG_RUPEE] = Item(RG_GREG_RUPEE, Text{"Greg Rupee", "Rubis Greg", "Rupia Greg"}, ITEMTYPE_ITEM, GI_RUPEE_GREEN, true, &Greg, GREG_RUPEE); | |||
There was a problem hiding this comment.
Since Greg is marked as an advancement item, this means that Greg will prevent "barren/foolish" hints if Greg is not in logic and is in a foolish area.
Short term solution could be to add a check for Greg and !GregInLogic into the IsMajorItem() in 3drando/item.hpp
Archez
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #2458, so i'm marking this as do not merge until that gets in
Build Artifacts