Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save skipped checks first pass #2476

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Save skipped checks first pass #2476

merged 1 commit into from
Feb 15, 2023

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Feb 15, 2023 •
edited by github-actions bot

Spent like 3 minutes reading through the check tracker and hacking this together for the race build and figured it'd be helpful to push up a PR, but not sure if this is the way we want to handle this, I have sorta been out of loop on check tracker stuff

Build Artifacts

briaguya-ai
briaguya-ai approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems perfectly reasonable to me, i'm digging into check tracker stuff right now

the first thing i'm going to try to implement is checked vs saved status, i don't think this steps on the toes of that work at all

@briaguya-ai briaguya-ai merged commit 462ab00 into HarbourMasters:develop Feb 15, 2023
@garrettjoecox garrettjoecox deleted the save-skipped-checks branch April 28, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garrettjoecox @briaguya-ai