Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use trick names for scrub and house of skulltula hints #2528

Merged
merged 3 commits into from
Feb 24, 2023
Merged

fix: use trick names for scrub and house of skulltula hints #2528

merged 3 commits into from
Feb 24, 2023

Conversation

briaguya-ai
Copy link
Contributor

@briaguya-ai briaguya-ai commented Feb 24, 2023 •
edited by github-actions bot

garrettjoecox
garrettjoecox approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I fully understand why scrubs would have been broken then fixed by this change, it looks like they should have been handled properly like shop items 🤔

@briaguya-ai
Copy link
Contributor Author

@garrettjoecox scrubs are Category::cDekuScrub, not Category::cShop, so we weren't making it into the if block before

@briaguya-ai briaguya-ai merged commit 95fe6b4 into HarbourMasters:develop Feb 24, 2023
@briaguya-ai briaguya-ai deleted the trick-name-fixes branch March 1, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@briaguya-ai @garrettjoecox