"greg the green rupee" #2529
Merged
"greg the green rupee" #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
approved these changes
Feb 24, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it so shops etc. show Greg as "Greg the Green Rupee" instead of "Greg Rupee"
I like this as a name, because while Greg is technically an acronym, I don't feel putting "Green Rupee of Eternal Glory" in as the name really fits.
Having it as "Greg Rupee" just gives me "Automatic Teller Machine Machine" vibes, but "Greg the Green Rupee" seems clear, and also ensures Greg is mentioned by name.
I'm open to other thoughts, just wanted to explain my reasoning.
Build Artifacts