make greg bridge more greg #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1035,6 +1037,15 @@ void ApplyOrResetCustomGfxPatches(bool manualChange = true) { | |||
| PATCH_GFX(gNintendo64LogoDL, "Title_N64LogoYellow2", n64LogoYellow.changedCvar, 82, gsDPSetEnvColor(color.r, color.g, color.b, 128)); | |||
| } | |||
|
|
|||
| // Greg Bridge | |||
| if (Randomizer_GetSettingValue(RSK_RAINBOW_BRIDGE) == RO_BRIDGE_GREG) { | |||
There was a problem hiding this comment.
Main drawback of putting it here is this will run either the unpatch or the patch every frame which isn't super great. Not sure I can think of a better way to handle it right now though
There was a problem hiding this comment.
yeah, i spent a while trying to think of a good spot for it, i kind of figured here works because it's where we're doing a ton of other patching
|
Should this match the color Greg is set to in the cosmetics editor? |
|
@RaelCappra not a bad idea, i'll try that out real quick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build Artifacts