Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Clean soh/CMakeLists #2556

Merged
merged 3 commits into from
Feb 28, 2023
Merged

[CMake] Clean soh/CMakeLists #2556

merged 3 commits into from
Feb 28, 2023

Conversation

dcvz
Copy link
Contributor

@dcvz dcvz commented Feb 28, 2023 •
edited by github-actions bot

dcvz
dcvz commented Feb 28, 2023
View reviewed changes
soh/soh/OTRInit.h
@@ -1 +0,0 @@
#pragma once
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File was not used and empty

aMannus
aMannus approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@aMannus aMannus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Looks good to me!

briaguya-ai
briaguya-ai approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dcvz dcvz merged commit 27d7cb0 into HarbourMasters:develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aMannus aMannus aMannus approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcvz @aMannus @briaguya-ai