Item_Give and OnReceiveItem updates #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollowing changes: Reworked the references to it in `z_parameter` to call a single function with the item return and hook call in it for ease of editing. Modified the pendingSale functionality to set and pass a modIndex value as well, as mod items (like randomizer) in shops still use the vanilla sale path.
Also added Randomizer_Item_Give to the OnReceiveItem system.
As a side effect, item autosave doesn't work for shop/scrub/merchant transactions, requires new OnSaleEnded hook that can also call the autosave.
Archez
reviewed
Mar 5, 2023
|
Yeah, I feel pretty silly about all those unnecessary RetrieveEntry calls now, lol. No, there's no reason for them. |
…ry properties were being used to call it. General code cleanup.
…ale. Migrated AutoSave to its own function, registered AutoSave function to OnReceiveItem and OnSaleEnd hooks to help with autsaving after buying items. Some futureproofing for AutoSave function with parameters for skipping autosave, for when transition end is migrated to AutoSave function (whether through direct call or through a hook).
|
Should be ready for merging pending another review. |
dcvz
reviewed
Mar 6, 2023
|
The call to |
|
Oh, and as a clarification, sale Item_Gives happen earlier than OnSaleEnd in other areas of code, but still utilize autosave limitations to prevent autosaving before rupee deduction. |
…a more descriptive alternative.
dcvz
reviewed
Mar 6, 2023
Refactored all references to OnReceiveItem to OnItemReceive to mirror upcoming full hook refactor for name ordering conventions. Up-to-date with develop.
dcvz
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnReceiveItemnow takes aGetItemEntryparameter to allow access to modIndex (futureproofing for mods).All access to that hook now feeds in the appropriate parameter.
Randomizer_Item_Givenow triggersOnReceiveItem.Shop item giving now also implements mod ID tracking to properly feed into
OnReceiveItemafter pending sales go through.Build Artifacts