[Time Saver Enhancement] Nighttime GS Always Spawn #2611
Conversation
|
You are right, it doesn't work in those areas. I didn't think about that being different |
Add onSceneSpawnActors hook and spawn Gold Skulltulas during day
|
Copying my description from the merged PR: "This PR adds a new With this hook we can then do various things like spawning "extra" actors. I've added an implementation of this hook for the "Night time GS always spawn" enhancement that will spawn Gold Skulltulas into the Day scene equivalent that are missing. There where 5 unique scenes (7 instances including different ages), with 12 unique GS actors overall that need to be spawned to make this enhancement work for all GS in the game. I ripped the position/rotation/params values from the Night scene spawn actor list." |
Handle the kak tree skull during the day
soh/soh/Enhancements/mods.cpp
Outdated
| if (IS_DAY && dayTimeGS.forChild == LINK_IS_CHILD && | ||
| dayTimeGS.scene == gPlayState->sceneNum && | ||
| dayTimeGS.room == gPlayState->roomCtx.curRoom.num) { | ||
| for (const auto actorEntry : dayTimeGS.actorEntries) { |
There was a problem hiding this comment.
Sorry, the important part was actually the &, not the const! Making them auto& refs instead of auto copies will potentially save performance by not copying the skulltula struct or actor list in every iteration of the for loops. I only mention it since it looks like you've got a merge conflict to take care of anyway.
There was a problem hiding this comment.
I read it too fast and missed the &, that's definitely my bad. Should be fixed now, as well as the merge conflicts
briaguya-ai
added
the
merge conflicts
Co-authored-by: Adam Bird <Archez@users.noreply.github.com>
Should be good now! |
Archez
removed
the
merge conflicts
Title pretty much explains it, but adds a checkbox in Time Savers to make the Gold Skulltulas that only spawn at night, spawn all the time. This speeds up things, since you no longer have to wait until night or rely on Suns Song to get them. Especially useful for Tokensanity.
Build Artifacts