Shopsanity Affordable Logic Update #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…05 depending on the selected wallet tier. Updated the tooltip to reflect.
|
Was this due to feedback on the current implementation? |
|
Yeah, apparently this was how many people were expecting it to be working, and Archez put the idea forward to make it a more even spread between the available tiers as well. Briaguya said that it was worth putting in khan because it was addressing an issue with what people were expecting. |
dcvz
approved these changes
Mar 13, 2023
aMannus
approved these changes
Mar 13, 2023
briaguya-ai
reviewed
Mar 13, 2023
|
Pushed the other changes briaguya suggested ala comments and variable names. If you're OK with keeping the functionality mentioned in the last unresolved conversation, then it's still ready for merging. |
One more function comment.
briaguya-ai
reviewed
Mar 13, 2023
briaguya-ai
reviewed
Mar 13, 2023
briaguya-ai
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Affordable shopsanity price logic to select from an array of "affordable prices" (one per tier) based on the tier of wallet selected. Given {10, 105, 205, 505}, each progressive tier adds one of those to the selection.
Starter -> 100% 10 rupees
Adult -> Selection between [10, 105] (50% chance)
Giant -> Selection between [10, 105, 205] (33% chance)
Tycoon -> Selection between all four (25% chance)
Also updated the tooltip for the Affordable toggle to reflect this (should be obvious this is what it's doing now, instead of confusing between this and the way I had it before).
Build Artifacts