Balanced Shopsanity Bugfix #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
requested changes
Mar 16, 2023
There was a problem hiding this comment.
I see a few issues with this:
- The added condition won't do anything, if
Settings::ShopsanityPrices.Is(RO_SHOPSANITY_PRICE_STARTER)then it will by definition not beSettings::ShopsanityPrices.Is(RO_SHOPSANITY_PRICE_BALANCED) - Even if that condition did work, we'd still go through the rest of the affordable logic, leading to the same error
- I tested it and i still got the crash
i think the real fix for this is changing the first couple lines of GetRandomShopPrice to be
// If Affordable is enabled, and we aren't using balanced prices, don't set max price
if (Settings::ShopsanityPricesAffordable.Is(true) && Settings::ShopsanityPrices.IsNot(RO_SHOPSANITY_PRICE_BALANCED)) {
return GetPriceAffordable();
}
|
That's what the fix was supposed to be, I just put it in the wrong spot in my codespace... Why am I so bad at this lately? XD |
briaguya-ai
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an unintended consequence of the changes briaguya suggested, and I implemented, in the affordable shopsanity update, it didn't register that the Affordable checkbox in Randomizer Settings retains its enabled or disabled status, so if someone selects Affordable and then changes the price range to Balanced, Affordable is still on, and thus GetPriceAffordable is called even without a wallet range, executing an out of range error. This fixes that.
Build Artifacts