Restore 1.0 quick Bongo kill glitch #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
reviewed
Mar 21, 2023
There was a problem hiding this comment.
Awesome, great job! Just left a small nitpick, but otherwise short and sweet.
Provided this does what it says it does without any side effects, I would be ok with merging it even without confirming against 1.0 so long as we investigate in the future to make it matching with 1.0 decomp/ASM
| @@ -356,12 +356,17 @@ void BossSst_HeadSetupLurk(BossSst* this) { | |||
| } | |||
|
|
|||
| void BossSst_HeadLurk(BossSst* this, PlayState* play) { | |||
| if (CVarGetInteger("gQuickBongoKill", 0)) | |||
There was a problem hiding this comment.
Nit: please use braces with multi-line if statements
| if (this->actor.yDistToPlayer < 1000.0f) { | ||
| BossSst_HeadSetupIntro(this, play); | ||
| } | ||
| } | ||
|
|
||
| void BossSst_HeadSetupIntro(BossSst* this, PlayState* play) { | ||
| //Make sure to restore original behavior if the quick kill didn't happen | ||
| if (CVarGetInteger("gQuickBongoKill", 0)) |
|
Done. |
briaguya-ai
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't have the decompiled 1.0 code to compare to, but looks good as far as I tested.
Build Artifacts