Fix: Mido softlocking textbox and blocking pathway when Link has Kokiri Emerald #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mido looks for Kokiri Emerald to decide if he should block the pathway and talk to you about the Deku Tree being dead. After the changes to make Mido prefer prompting for sword and shield for dungeon entrance rando, the text for talking about the tree being dead would never run, causing him to stay in the way.
This updates all the Kokiri emerald checks to account for randomizer and check for the randomizerInf flag for deku completion instead. I also restored the dead tree text ID, but still preserving the sword and shield check to happen first. Clearing the deku tree will also mark the flag for talking to Mido about the dead tree.
So now having or not having Kokiri emerald should not change how Mido acts. Sword and Shield check still has the highest priority, and the deku tree clear flag is used instead.
Build Artifacts