Equip dupe fix

[inspectredc]

This PR reintroduces equip duping which was removed in https://github.com/HarbourMasters/Shipwright/pull/525 which introduced dpad equips.

In the original game elemental arrows temporarily use different addresses (0xBF to 0xC1) for the equipTargetItem index. The code later checks for these values to correct them while it also does checks to swap items in cases where the equipTargetSlot is the same as items on the cButtonSlots. These extra steps were removed with the introduction of dpad equips. Instead the elemental arrows' equipTargetItem indexes were corrected before these checks. I believe this is what lead to the removal of unnecessary checks that the original would do, including a check that would swap the equips when the equipTargetItem is bow and an elemental arrow is equipped to a different buttonItems slot than the equipTargetCBtn. It is this check which is triggered only when performing equip dupe and as the current swapping only looks for the equipTargetSlots and not the removed bow case. This PR readds this case into the buttonItems swap loop.

Build Artifacts

• soh-linux-compatibility.zip
• soh-linux-performance.zip
• soh-mac.zip
• soh-switch.zip
• soh-wiiu.zip
• soh-windows.zip

[inspectredc]

Just to try and help this along with the review:

Here is the section which would allow for equip duping in the original code

Shipwright/soh/src/overlays/misc/ovl_kaleido_scope/z_kaleido_item.c

Lines 638 to 650 in 2b0af54

	} else if (pauseCtx->equipTargetItem == ITEM_BOW) {
	if ((gSaveContext.equips.buttonItems[2] >= ITEM_BOW_ARROW_FIRE) &&
	(gSaveContext.equips.buttonItems[2] <= ITEM_BOW_ARROW_LIGHT)) {
	gSaveContext.equips.buttonItems[2] = gSaveContext.equips.buttonItems[1];
	gSaveContext.equips.cButtonSlots[1] = gSaveContext.equips.cButtonSlots[0];
	Interface_LoadItemIcon2(globalCtx, 2);
	} else if ((gSaveContext.equips.buttonItems[3] >= ITEM_BOW_ARROW_FIRE) &&
	(gSaveContext.equips.buttonItems[3] <= ITEM_BOW_ARROW_LIGHT)) {
	gSaveContext.equips.buttonItems[3] = gSaveContext.equips.buttonItems[1];
	gSaveContext.equips.cButtonSlots[2] = gSaveContext.equips.cButtonSlots[0];
	Interface_LoadItemIcon2(globalCtx, 3);
	}
	}

(repeated again for each button later on)

This PR just condenses that section back into the code to fit in with the dpad equips without having to have all the repeated statements

[garrettjoecox]

LGTM