Fix: Spirit Cobra statue shadow and small doc updates #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
commented
Apr 3, 2023
Comment on lines
+588
to
+592
| // Fixes cobra statue shadow texture not updating when rotating it | ||
| if (this->actionFunc == func_80896ABC) { | ||
| gSPInvalidateTexCache(POLY_XLU_DISP++, COBRA_SHADOW_TEX_PTR(this)); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is basically the main fix for the texture updating (in addition to the helper macro)
briaguya-ai
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the shadows on the Cobra statues were not updating when the statue is rotated. This required adding a texture invalidation for the shadow. The invalidation only happens when the statue rotates (checking against the current
actionFunc).While working in this file, I took the time to bring over doc updates/changes from decomp (since it was relatively small).
If we feel this should be moved to a separate PR, then I can do that too and just leave the shadow texture fix.
Fixes #2341
Build Artifacts