Fix: Rando logic MQ Jabu clear condition for boss entrance rando #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
looks like this is gamestabled/OoT3D_Randomizer#666
perfect! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for MQ Jabu had it such that entering the room before Jabu's boss room would set the clear condition, meaning "All locations Reachable" would consider Barinades items as reachable even if child could not get to the boss room contains Barinade (e.g. Water Temple Boss Door).
This just removes the logic event as it already correctly exists in the boss region for Barinade further below.
Build Artifacts