-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement: Additional Spoiler Hint Info #2727
Merged
leggettc18
merged 20 commits into
HarbourMasters:develop
from
Malkierian:spoiler-hint-data
Jun 2, 2023
Merged
Improvement: Additional Spoiler Hint Info #2727
leggettc18
merged 20 commits into
HarbourMasters:develop
from
Malkierian:spoiler-hint-data
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… more than a hint tracker.
…item for gossip stone hints.
… the check. Any overworld or dungeon region hint no longer does.
…, and `RandomizerGet` names. Currently only English names. Part of this required changing `HintType` into a `typedef enum` instead of an `enum class` to allow usage in a .c filespace, and consolidating types from `randomizer_check_objects.h` to `randomizerTypes.h`.
…e spoiler log. Added a few entries to `SpoilerfileAreaNameToEnum` to accommodate area name variants from region hint names.
…k` translation. `RandomizerCheck` provides access to `RandomizerCheckArea` via `RandomizerCheckObject`). Added Light Arrows, Greg, and Dampe's Hookshot hint locations to write and read of the spoiler.
leggettc18
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional hint information as follows:
Expanded altar text hints including locations for each medallion/stone, grouped under the respective age group.
Locations for Dampe's Hookshot, Greg the Green Rupee, and Ganon's LA hints.
Information on all gossip stone hints, including type (Item, WotH, Junk, Barren), area, item name, and check, where applicable:
Also properly loads them into the save context and are properly read from their new structures when appropriate in game.
Build Artifacts