Tweak: Reset trade item cycling when pausing or changing pages #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspectredc
reviewed
Apr 30, 2023
That's a good point. Can't think of a situation where that would fail, but easy enough to move anyways. |
Archez
changed the title
inspectredc
approved these changes
May 1, 2023
briaguya-ai
approved these changes
May 4, 2023
leggettc18
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have flags that track when the player is in a "trade item cycling" mode for adult/child trade items. This mode is unset if you press A again, or equip the item to a C-button. However, if you press B or Start to unpause while mid-cycling, the next time you pause you are still in the cycling state.
I added a method that is called at beginning of the pause init flow that will manually set these flags back to false to address this. I also call this method when the kelido page is switched left or right.
Fixes #2794
Build Artifacts