Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWEAK: Rupee dash duplication #2815

Merged
merged 2 commits into from
May 4, 2023

Conversation

PurpleHato
Copy link
Contributor

@PurpleHato PurpleHato commented May 1, 2023

Rupee dash was duplicated while being moved over the EXTRA MODES, so this fixes the duplication and put it only there

Build Artifacts

Rupee dash was duplicated while being moved over the EXTRA MODES, so this fixes the duplication and put it only there
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like one of the old instances had the slider hidden when rupee dash was disabled, while the other instance didn't. i'd lean towards hiding the slider when dash is disabled

@leggettc18 leggettc18 added the do not merge Not ready or not valid changes label May 4, 2023
soh/soh/GameMenuBar.cpp Outdated Show resolved Hide resolved
@leggettc18 leggettc18 removed the do not merge Not ready or not valid changes label May 4, 2023
@leggettc18 leggettc18 merged commit d025ca0 into HarbourMasters:develop-spock May 4, 2023
7 checks passed
@PurpleHato PurpleHato deleted the rupee-dash branch May 4, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants