Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lus updates #2822

Merged
merged 6 commits into from
May 4, 2023
Merged

Lus updates #2822

merged 6 commits into from
May 4, 2023

Conversation

Kenix3
Copy link
Collaborator

@Kenix3 Kenix3 commented May 3, 2023

Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

condensed changelog:
SohImGui -> Ship
ResourceMgr -> ResourceManager
OtrFile -> File
ResourceManager.GetGameVersions() is gone, now use ResourceManager.GetArchive().GetGameVersions()
OTRGlobals::Instance->context->ReadSaveFile -> SaveManager::ReadSaveFile
OTRGlobals::Instance->context->WriteSaveFile -> SaveManager::WriteSaveFile

@@ -1584,5 +1584,6 @@ void DebugConsole_Init(void) {
{ "reset|randomize", Ship::ArgumentType::TEXT },
}});

CVarSave();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear why this is being added, anyone have context as to why we have this or load here?

soh/soh/GameMenuBar.cpp Outdated Show resolved Hide resolved
@briaguya-ai briaguya-ai mentioned this pull request May 3, 2023
@briaguya-ai briaguya-ai changed the base branch from develop to develop-spock May 3, 2023 06:33
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to build on switch and wii u this needs the changes from Kenix3/libultraship#191 and this suggestion #2822 (comment)

I was able to test on switch and it's working just fine. I tried using an older version of the devkitppc docker image to build in a way that i could test on cemu and while the build succeeded the testing didn't so getting wii u builds to work can be a separate thing

@leggettc18 leggettc18 merged commit 4980ae8 into develop-spock May 4, 2023
13 checks passed
@briaguya-ai briaguya-ai deleted the lus_updates branch May 4, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants