-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lus updates #2822
Lus updates #2822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condensed changelog:
SohImGui
-> Ship
ResourceMgr
-> ResourceManager
OtrFile
-> File
ResourceManager.GetGameVersions()
is gone, now use ResourceManager.GetArchive().GetGameVersions()
OTRGlobals::Instance->context->ReadSaveFile
-> SaveManager::ReadSaveFile
OTRGlobals::Instance->context->WriteSaveFile
-> SaveManager::WriteSaveFile
@@ -1584,5 +1584,6 @@ void DebugConsole_Init(void) { | |||
{ "reset|randomize", Ship::ArgumentType::TEXT }, | |||
}}); | |||
|
|||
CVarSave(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not clear why this is being added, anyone have context as to why we have this or load here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to build on switch and wii u this needs the changes from Kenix3/libultraship#191 and this suggestion #2822 (comment)
I was able to test on switch and it's working just fine. I tried using an older version of the devkitppc docker image to build in a way that i could test on cemu and while the build succeeded the testing didn't so getting wii u builds to work can be a separate thing
null
Build Artifacts