ShadowTag (7.0.1) #2825
Merged
ShadowTag (7.0.1) #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spawn Code in mods.cpp Category Change for Clear Room Exclusion Kill Actor if Mode is Disabled
Update to 7.0.1
Update to 7.0.1
… firing on quick room changes like falling to B1 in Tree and Lost Woods loading triggers.
briaguya-ai
reviewed
May 16, 2023
Comment on lines
+435
to
+436
| if (!CVarGetInteger("gShadowTag", 0)) { | ||
| Actor_Kill(&this->actor); |
There was a problem hiding this comment.
so is the idea here that after turning off shadow tag you need to hit the wallmaster once (or wait for it to return to the ceiling) before it'll go away?
There was a problem hiding this comment.
Exactly, instead of interrupting the execution process, just let it finish out the last process and kill it. (or change rooms/scene)
leggettc18
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallmaster follows link everywhere
Added ShadowTag Checkbox to Extra Modes
Spawn Code in mods.cpp
Category Change for Clear Room Exclusion
Kill Actor if Mode is Disabled
Build Artifacts