Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Cutscene Pointer Button/Cheat #2837

Merged
merged 4 commits into from Oct 2, 2023

Conversation

inspectredc
Copy link
Contributor

@inspectredc inspectredc commented May 5, 2023

@garrettjoecox
Copy link
Contributor

Is this a cheat or a debug tool? Code looks good, just not sure where it belongs

@inspectredc
Copy link
Contributor Author

Yea I wasn't really sure where to put it, I thought cheat since it's main use is for speedrunning practice purposes and didn't seem right under enhancements or dev tools

@stratomaster64
Copy link
Contributor

Yea I wasn't really sure where to put it, I thought cheat since it's main use is for speedrunning practice purposes and didn't seem right under enhancements or dev tools

To be fair, a lot of gz's functionality was lifted off their cheats.

soh/soh/GameMenuBar.cpp Outdated Show resolved Hide resolved
@inspectredc
Copy link
Contributor Author

Made changes for using RawAction now 👍🏼 My main concern now is just about maybe giving some feedback that it succeeded since there's no visual change? but not sure if that'd be necessary

@inspectredc inspectredc changed the title Clear Custcene Pointer Button/Cheat Clear Cutscene Pointer Button/Cheat Jun 7, 2023
@garrettjoecox
Copy link
Contributor

@inspectredc what scenarios require using this cheat? I'm wondering if this should rather be on the improved debug warp screen or something.

@inspectredc
Copy link
Contributor Author

@inspectredc what scenarios require using this cheat? I'm wondering if this should rather be on the improved debug warp screen or something.

This is something that speedrunners use when practicing wrong warps. Basically the cutscene pointer is read when a wrong warp happens and will usually be bad data which will cause the wrong warp to softlock. The cheat clears the data to point to a safe value which will not cause a softlock, allowing the wrong warp to work.

Since the way the cutscene pointers data is manipulated in soh is different to n64 (and I think infeasible to replicate) this will help with testing/performing these tricks even more.

@garrettjoecox garrettjoecox added the merge conflicts PR has conflicts that need to be resolved before it can be merged label Aug 30, 2023
@inspectredc
Copy link
Contributor Author

Should hopefully still be clear of merge conflicts

@garrettjoecox garrettjoecox merged commit 82d87ff into HarbourMasters:develop Oct 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts PR has conflicts that need to be resolved before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants