Cleanup cvars that are set on boot and in the navigation #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archez
reviewed
May 9, 2023
Archez
reviewed
May 9, 2023
garrettjoecox
force-pushed
the
cleanup-startup-cvars
branch
from
fb79077
to
47d9138
Compare
briaguya-ai
reviewed
May 9, 2023
leggettc18
approved these changes
May 10, 2023
garrettjoecox
force-pushed
the
cleanup-startup-cvars
branch
3 times, most recently
from
f4f6217
to
6d16088
Compare
garrettjoecox
force-pushed
the
cleanup-startup-cvars
branch
from
6d16088
to
46a705b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clean up the cvars so that when users back them up or share them they aren't littered with changes they didn't make.
This PR will be accompanied by a smaller PR to LUS (Kenix3/libultraship#204)
This is achieved by:
One intentional change with this PR is all windows are consistent now, and will preserve their open/close state through a restart. I see no reason why we should have inconsistency here anyway.
When booting + opening nav before this PR:
When booting + opening nav after this PR:
Build Artifacts