Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UTF-8 for MSVC and enable visual styles for Windows #2888

Merged
merged 2 commits into from May 18, 2023

Conversation

xoascf
Copy link
Contributor

@xoascf xoascf commented May 13, 2023

Build Artifacts

Copy link
Contributor

@leggettc18 leggettc18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is, not opposed to this making it in, but I have a few questions. Some of them were left as code comments, and one is below:

Is there some tangible affect of the manifest that I would actually be able to see? If it's just that having a manifest is a correctness thing that's fine, just curious if I could actually do something with this to verify that it's working.

soh/SHIPOFHARKINIAN.manifest Show resolved Hide resolved
soh/CMakeLists.txt Show resolved Hide resolved
@xoascf
Copy link
Contributor Author

xoascf commented May 17, 2023

Is there some tangible affect of the manifest that I would actually be able to see? If it's just that having a manifest is a correctness thing that's fine, just curious if I could actually do something with this to verify that it's working.

Yep, you can see the difference when running the ROM extraction process.

Before:
before

With this PR:
after

@leggettc18
Copy link
Contributor

Perfect, the difference on Windows 11 for reference. Left is Spock Bravo, right is this PR:
image

@leggettc18 leggettc18 merged commit b361d5e into HarbourMasters:develop-spock May 18, 2023
7 checks passed
@xoascf xoascf deleted the windows-misc branch May 18, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants