Add Scene Specific Checks to Dirt Path Fixes

[Patrick12115]

This makes it to where it only activates in the specific scenes with paths. (Hyrule Field, Hyrule Castle, and Kokiri Forest)

It will then be disabled in any other scenes, so that other decals, like scrub shadows, are not affected.

Moved from develop PR #2903 to develop-spock

Build Artifacts

• soh.otr.zip
• soh-linux-compatibility.zip
• soh-linux-performance.zip
• soh-mac.zip
• soh-switch.zip
• soh-windows.zip

[briaguya-ai]

not the biggest fan of UpdateDirtPathFixState and gSceneSpecificDirtPathFix as names but nothing good is coming to mind so i don't want to let that block this

[Patrick12115]

Yeah, if anyone has any better names, I'm all for it. haha. Just went with what I thought would be easyish to understand what it was doing. And stole the other one from Proxy haha.

[briaguya-ai]

my issue with gSceneSpecificDirtPathFix and gDirtPathFix is it feels like when gSceneSpecificDirtPathFix is true that should mean we want the fix for this scene, and when gDirtPathFix is true it means we want to fix dirt paths, but they're being used to mean the opposite

i know that's because changing gDirtPathFix would require LUS changes. i feel like if we could change both names it'd be easy to come up with good ones, but trying to come up with a good name when we're stuck with gDirtPathFix meaning "apply the dirt path fix in fast3d without checking what scene we're in" it makes it tough

as for UpdateDirtPathFixState - i feel like maybe ConditionallyApplyDirtPathFix could work?

[garrettjoecox]

not the biggest fan of UpdateDirtPathFixState and gSceneSpecificDirtPathFix as names but nothing good is coming to mind so i don't want to let that block this

I think the CVAR used in LUS is probably the issue here but more annoying to change. CVAR in LUS should be gZFightingMode, and then within SoH this new cvar should be gDirtPathFix, and the update method could be something like UpdateZFightingModeForDirtPathFix, maybe a bit verbose but it says what it does.

[briaguya-ai]

@garrettjoecox i like that plan, want to make an issue to update the LUS cvar so we can have decent names in sulu?

[Patrick12115]

Want me to go ahead and change all that on my side, now? Or wait?

[garrettjoecox]

@garrettjoecox i like that plan, want to make an issue to update the LUS cvar so we can have decent names in sulu?

Kenix3/libultraship#278

Want me to go ahead and change all that on my side, now? Or wait?

I think there's some stuff in flight with LUS so probably we stick with the weird names for now and change for sulu, I'll differ to Bria though

[briaguya-ai]

yeah, let's get this one in as-is for spock and worry about names when we can change things everywhere