V1 - Chestapalooza #2922
V1 - Chestapalooza #2922
Conversation
soh/soh/Enhancements/mods.cpp
Outdated
| switch (roll) { | ||
| case 1: | ||
| if (!CVarGetInteger("gChestIce", 0)) { | ||
| GameInteractor::RawAction::FreezePlayer(); |
There was a problem hiding this comment.
In addition to that, you could then handle the determination of what effect to apply with a unified function GameInteractor::RawAction::PlayerEffect or maybe DamageEffect, not sure. This would then just accept an effect enum value and apply the correct one internally. This is more of a suggestion, and probably down to preference, but other devs who have worked with this project more could probably chime in.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
I like the cutesy name but it's not intuitive 🗡️ I'd replace both the method/display name as well as the cvars to something more clear, and you can nest the cvars. Something like etc, doesn't have to be this but should be clear on what it is. |
|
Just so it's not lost in DM's, I'd also recommend building out an array of available traps and choosing one from the available array so there is an even distribution (I sent you the code snippet PoC for this) |
Did you see my suggestion about the enum and such? I think we were talking about the same section, just wondering if we had the same idea, or our ideas would supplement each other or what. |
yup I think we were on the same page there 👍 |
Create and use OnTrapProcessed hook
New Hook for Rando traps. Restore Vanilla code for ice traps.
| Player* player = GET_PLAYER(gPlayState); | ||
| player->actor.colChkInfo.damage = 0; | ||
| func_80837C0C(gPlayState, player, 3, 0, 0, 0, 0); |
There was a problem hiding this comment.
This change was required because the ice traps can now be processed by game interactor, so this caused a infinite loop of ice traps. Not sure if there is a better way to handle this..
Co-authored-by: Garrett Cox <garrettjcox@gmail.com>
|
@briaguya-ai / @leggettc18 / anyone this is ready for another look. Me and cal paired and got it working from all check types with a new hook but I'm not sure how I feel about the solution yet. Looking for feedback |
There was a problem hiding this comment.
From what I can see, it looks good and doesn't seem to complicate the existing codebase. It would be helpful to conduct some playtesting to ensure its functionality and effectiveness. So I would say LGTM so far
Overall, this pr appears to be in good shape and adds something that I was looking forward. Thank you for your work on this!
More tweaks, remove processed trap hook
There was a problem hiding this comment.
Did another pass on this to remove the new hook and just use OnItemReceive, as well as clean up how ice traps emit the OnItemReceive hook
This has been playtested for a month or so now on Anchor. Would be nice to get at least one other maintainers' eyes on it since some of it is my code.
This is as good as my skill set could get for a V1. Sending a PR in hopes of some code review and helpful pointers for cleanliness.
Everything is operational in its current state, and each trap can be toggled off which will revert it back to a normal Ice Trap.
Freeze Trap
Shock Trap
Burn Trap
Explosion Trap
Knockback Trap
Teleport Trap
Void Trap
Death Trap
Ammo Consumption Trap
Speed Trap
I'll add more in V2 or V3. hoping to utilize some future commits i see in the works to enable custom trap messages per trap type.
Build Artifacts