Rename gDirtPathFix to gZFightingMode #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
approved these changes
Jun 6, 2023
|
once the config versioning is in we should be able to migrate this setting to the new name |
garrettjoecox
force-pushed
the
rename-dirt-path-fi
branch
from
5f0c0ea
to
d720bd5
Compare
leggettc18
requested changes
Jun 12, 2023
There was a problem hiding this comment.
Config Versioning is in, please make a new config version to rename the setting in existing configs. Check out the files in soh/soh/config and the end of InitOTR in OTRGlobals.cpp to see how to add a new config version. Let me know if you need any help with that.
garrettjoecox
force-pushed
the
rename-dirt-path-fi
branch
from
d720bd5
to
4278660
Compare
|
garrettjoecox
force-pushed
the
rename-dirt-path-fi
branch
from
4278660
to
64abc4d
Compare
leggettc18
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for Kenix3/libultraship#278 (came in with 1.0)
Build Artifacts