New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an error for implicit functions #3017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louist103
changed the title
Add the flag and fix errors
Add an error for implicit functions
Jun 18, 2023
Signed-off-by: Louis <louist103@pop-os.localdomain>
leggettc18
reviewed
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a small merge conflict appeared after I merged Proxy's flag stuff PR. Pending that, I just had one other question, but it's looking pretty good otherwise.
leggettc18
approved these changes
Jun 27, 2023
Pepper0ni
pushed a commit
to Pepper0ni/Shipwright
that referenced
this pull request
Aug 3, 2023
* Add the flag and fix errors * switch assert and skin matrix * new LUS * Use normal assert * hopefully fix WiiU Signed-off-by: Louis <louist103@pop-os.localdomain> --------- Signed-off-by: Louis <louist103@pop-os.localdomain> Co-authored-by: Louis <louist103@pop-os.localdomain> Co-authored-by: Christopher Leggett <chris@leggett.dev>
Archez
pushed a commit
to Archez/Shipwright
that referenced
this pull request
Aug 5, 2023
* Add the flag and fix errors * switch assert and skin matrix * new LUS * Use normal assert * hopefully fix WiiU Signed-off-by: Louis <louist103@pop-os.localdomain> --------- Signed-off-by: Louis <louist103@pop-os.localdomain> Co-authored-by: Louis <louist103@pop-os.localdomain> Co-authored-by: Christopher Leggett <chris@leggett.dev>
Archez
added a commit
to Archez/Shipwright
that referenced
this pull request
Aug 5, 2023
commit e68d300 Author: aMannus <mannusmenting@gmail.com> Date: Sat Jul 22 20:04:05 2023 +0200 Fix timer completion & 50+ triforce pieces commit 4423f94 Author: aMannus <mannusmenting@gmail.com> Date: Wed Jul 12 12:26:17 2023 +0200 Finish translations commit e26a05f Author: aMannus <mannusmenting@gmail.com> Date: Wed Jul 5 20:35:13 2023 +0200 French translation and update defaults commit 8e7f0e0 Author: aMannus <mannusmenting@gmail.com> Date: Tue Jul 4 09:40:39 2023 +0200 Small ImGui adjustments commit 0b20570 Author: aMannus <mannusmenting@gmail.com> Date: Tue Jul 4 09:28:51 2023 +0200 Update Item Tracker Settings initial size commit c5aeda3 Author: aMannus <mannusmenting@gmail.com> Date: Tue Jul 4 08:53:58 2023 +0200 Forced save on completion improvements commit 0095e63 Author: aMannus <mannusmenting@gmail.com> Date: Mon Jul 3 20:37:37 2023 +0200 Clean-up commit 01cb50a Author: aMannus <mannusmenting@gmail.com> Date: Mon Jul 3 20:19:42 2023 +0200 Disable GBK option in ImGui with Triforce Hunt on commit 8570dc2 Author: aMannus <mannusmenting@gmail.com> Date: Mon Jul 3 19:49:44 2023 +0200 Better text boxes commit c4d6580 Author: aMannus <mannusmenting@gmail.com> Date: Mon Jul 3 14:14:47 2023 +0200 Grant GBK to player after hunt is completed commit 4114ce2 Author: aMannus <mannusmenting@gmail.com> Date: Mon Jul 3 13:40:41 2023 +0200 Triforce pieces can show up as icetraps commit 510af61 Author: aMannus <mannusmenting@gmail.com> Date: Sun Jul 2 22:19:22 2023 +0200 Bit of cleanup commit d52cffc Author: aMannus <mannusmenting@gmail.com> Date: Sun Jul 2 22:13:48 2023 +0200 Start of making Triforce Hunt the win condition commit 852f1c4 Author: aMannus <mannusmenting@gmail.com> Date: Sun Jul 2 18:03:02 2023 +0200 More reverting commit 41020b2 Author: aMannus <mannusmenting@gmail.com> Date: Sun Jul 2 17:57:22 2023 +0200 Revert parts of logic commit eae8df8 Author: aMannus <mannusmenting@gmail.com> Date: Sun Jul 2 14:45:35 2023 +0200 Gameplaystats timestamp commit 34d8189 Author: aMannus <mannusmenting@gmail.com> Date: Sun Jul 2 13:24:03 2023 +0200 Finish item tracker commit 27eec6b Author: aMannus <mannusmenting@gmail.com> Date: Sun Jul 2 13:00:20 2023 +0200 Triforce pieces in save editor & fix build commit 61ec6dc Author: aMannus <mannusmenting@gmail.com> Date: Sun Jul 2 12:50:20 2023 +0200 Multiple triforce piece models commit 57bd911 Author: aMannus <mannusmenting@gmail.com> Date: Sat Jul 1 22:59:44 2023 +0200 Completed triforce model on GI done commit d4df0f3 Author: aMannus <mannusmenting@gmail.com> Date: Sat Jul 1 17:58:09 2023 +0200 Completed triangle on triforce completion commit 8303d1e Author: aMannus <mannusmenting@gmail.com> Date: Sat Jul 1 15:00:25 2023 +0200 Initial item tracker stuff commit 93984b3 Author: aMannus <mannusmenting@gmail.com> Date: Fri Jun 30 21:41:40 2023 +0200 Credits warp + start of item tracker commit 1de7097 Author: aMannus <mannusmenting@gmail.com> Date: Fri Jun 30 16:28:04 2023 +0200 Triforce model is now a shard commit a82f591 Author: aMannus <mannusmenting@gmail.com> Date: Fri Jun 30 16:15:43 2023 +0200 Better triforce model, finish adding triforce pieces to logic commit 08b2931 Author: aMannus <mannusmenting@gmail.com> Date: Fri Jun 30 12:03:51 2023 +0200 Disable triforce greyscaling commit 5c441f1 Author: aMannus <mannusmenting@gmail.com> Date: Fri Jun 30 11:43:03 2023 +0200 Initial work to make triforce pieces their own rando item commit acfc04d Author: louist103 <35883445+louist103@users.noreply.github.com> Date: Tue Jun 27 19:53:35 2023 -0400 Add an error for implicit functions (HarbourMasters#3017) * Add the flag and fix errors * switch assert and skin matrix * new LUS * Use normal assert * hopefully fix WiiU Signed-off-by: Louis <louist103@pop-os.localdomain> --------- Signed-off-by: Louis <louist103@pop-os.localdomain> Co-authored-by: Louis <louist103@pop-os.localdomain> Co-authored-by: Christopher Leggett <chris@leggett.dev> commit 7c5efb2 Author: Garrett Cox <garrettjcox@gmail.com> Date: Tue Jun 20 10:54:02 2023 -0500 Flags stuff (HarbourMasters#3014) * Manual adjustments to flags * Script run to adjust flags
louist103
added a commit
to louist103/Shipwright-1
that referenced
this pull request
Aug 11, 2023
* Add the flag and fix errors * switch assert and skin matrix * new LUS * Use normal assert * hopefully fix WiiU Signed-off-by: Louis <louist103@pop-os.localdomain> --------- Signed-off-by: Louis <louist103@pop-os.localdomain> Co-authored-by: Louis <louist103@pop-os.localdomain> Co-authored-by: Christopher Leggett <chris@leggett.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null
Build Artifacts