Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exact item and check to the spoiler log for WotH hints #3043

Merged
merged 1 commit into from Jul 2, 2023

Conversation

Pepper0ni
Copy link
Contributor

As title.

Do i need to provide builds for this 2 line change?

@leggettc18
Copy link
Contributor

You don't need to provide builds, the CI will build automatically once I approve the workflow to run. You are a first time contributor so we have to approve your changes for CI to run on manually once.

Just so I'm clear, before now WOTH hints weren't being added to the spoiler log at all? If so, that sounds like a bug, which means we would want this to go to the develop-sulu branch so it can get into Sulu Bravo. Can you rebase this change onto that branch?

@leggettc18 leggettc18 added this to the Sulu Bravo (7.1.1) milestone Jun 28, 2023
@Malkierian
Copy link
Contributor

Malkierian commented Jun 28, 2023

No, they were being added, but only had the WotH type, area, and hint text in the spoiler. This adds exact check and item being referenced to the WotH hint entries in the spoiler specifically.

@leggettc18
Copy link
Contributor

Ah ok, I still think it probably should have already been in the spoiler log and this change should probably get rebased to develop-sulu, but I'm down to hear other opinions on this one.

@Malkierian
Copy link
Contributor

I mean, before my hint expansion PR, it was just printing the hint text, and that wasn't targeted as a bugfix, so this is just an expansion of that basically. Only error was oversight, really.

@Pepper0ni Pepper0ni changed the base branch from develop to develop-sulu June 28, 2023 12:36
@leggettc18 leggettc18 merged commit 531b346 into HarbourMasters:develop-sulu Jul 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants