Fix: Various PAL GC asset offset issues #3052
Conversation
| @@ -1,21 +1,21 @@ | |||
| <Root> | |||
| <File Name="ovl_En_Ganon_Mant" BaseAddress="0x80A23D60" RangeStart="0x1218" RangeEnd="0x4118"> | |||
| <Texture Name="gMantTex" OutName="mant" Format="rgba16" Width="32" Height="64" Offset="0x1218"/> | |||
| <File Name="ovl_En_Ganon_Mant" BaseAddress="0x80A0BCC0" RangeStart="0x11F8" RangeEnd="0x40F8"> | |||
There was a problem hiding this comment.
I'm confident about all the changes I made except for the BaseAddress= in these three files. I'm not sure the proper way to find them out.
Instead what I did was run ZAPD, and during the DL parsing it would throw an error saying the referenced texture address is below the base address.
In this case, the referenced texture is the first in each of these files, so I took the textures address, subtracted the offset, and used that as the BaseAddress. Obviously I tested the changes and everything works. Just want to make sure that anyone who understands it better can verify.
/cc @NEstelami
|
As long as we're OK with requiring regen OTRs to fix minor graphical bugs in a bugfix release. As stated in the other PR, my opinion is that having this OTR generation bugfix in a bugfix release is fine since 1. it isn't required for the game to not crash, just fixes minor graphical bugs, and 2. It's only for 1 type of ROM, and 3. Support for said ROM was just added last release. |
|
To add to the reasoning behind version bumps. A major version bump has historically meant "old |
Fixes some various asset offset issues for PAL GC:
Targeting Sulu as not re-generating an OTR doesn't cause any crashes.
Fixes #2994, #2993, #2992
Build Artifacts