Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-in for an easy-way CMake target to create soh.otr file #3057

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Opt-in for an easy-way CMake target to create soh.otr file #3057

merged 4 commits into from
Aug 16, 2023

Conversation

Alto1772
Copy link
Contributor

@Alto1772 Alto1772 commented Jul 2, 2023 •
edited by github-actions bot
Loading

Archez
Archez approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find myself having to make local modifications to basically do a similar thing whenever I am working on asset changes. This change is very welcomed, thank you!

@garrettjoecox
Copy link
Contributor

Marking as merge ready. Will merge in a day or two

@garrettjoecox garrettjoecox merged commit 6923c2d into HarbourMasters:develop Aug 16, 2023
8 checks passed
@Alto1772 Alto1772 deleted the cmake-target-sohotr branch November 8, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez approved these changes

Assignees
No one assigned
Labels
merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alto1772 @garrettjoecox @Archez