Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag set/unset hooks and GI actions #3065

Merged
merged 1 commit into from Sep 26, 2023
Merged

Add flag set/unset hooks and GI actions #3065

merged 1 commit into from Sep 26, 2023

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Jul 3, 2023 •
edited by github-actions bot

briaguya-ai
briaguya-ai reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great! Super happy to see this improvement in functionality. I feel like the (int)log2( stuff is less than ideal though. I left some comments with ideas for how to avoid the math includes and int casts.

soh/src/overlays/actors/ovl_En_Fr/z_en_fr.c Outdated Show resolved Hide resolved
soh/src/overlays/actors/ovl_En_Daiku/z_en_daiku.c Outdated Show resolved Hide resolved
soh/src/overlays/actors/ovl_En_Sth/z_en_sth.c Outdated Show resolved Hide resolved
@garrettjoecox
Copy link
Contributor Author

Overall this looks great! Super happy to see this improvement in functionality. I feel like the (int)log2( stuff is less than ideal though. I left some comments with ideas for how to avoid the math includes and int casts.

@briaguya-ai @Archez how's this look? https://github.com/HarbourMasters/Shipwright/compare/4e2fef251014a3d3ef2a72513c4b7f101c7ad3bc..55b2e66c770d4eba4d0f6c8674210edbdad3061b

Archez
Archez approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now 👍

briaguya-ai
briaguya-ai approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@garrettjoecox garrettjoecox merged commit db10864 into HarbourMasters:develop Sep 26, 2023
8 checks passed
@garrettjoecox garrettjoecox deleted the flagsHooks branch September 26, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garrettjoecox @Archez @briaguya-ai