Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice tab to Audio Editor #3080

Merged
merged 7 commits into from Aug 20, 2023

Conversation

LuigiXHero
Copy link
Contributor

@LuigiXHero LuigiXHero commented Jul 14, 2023

Todo:

  • Make the option to include sound effects and voices together in their pools work. Gonna wait on Fanfares as possible outcomes for randomizing ocarina songs in the Audio Editor #2714 for the code for randomizing multiple groups together.
  • Figure out how to shuffle sound effects with "- SFX_FLAG" on it, currently they are commented out. This includes hover boots and the voice samples for both ages drinking a bottle. This flag seems to indicate a sfx that loops if you omit it the sfx loops forever but shuffle will then work. This can wait for a follow PR
  • Testing

This adds a new tab to the audio editor called voices:
Includes every voice that that the game considers a voice, based on being named VO note that means any enemy sound effects that are voices don't count for this. This includes child and adult link voices as well as npcs.
image

Build Artifacts

LuigiXHero added 4 commits July 10, 2023 20:27
Todo: rename rest of entries and reorganize it into a new tab
Also make it, it's own tab. Added the option.
@LuigiXHero LuigiXHero marked this pull request as ready for review July 14, 2023 06:46
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far. Are you wrapped up on this or do you intend on continuing to iterate?

soh/soh/Enhancements/audio/AudioCollection.h Outdated Show resolved Hide resolved
@LuigiXHero
Copy link
Contributor Author

Looking good so far. Are you wrapped up on this or do you intend on continuing to iterate?

This is fine for a v1 of this since I have no idea on how to fix the SFX_FLAG issue and the other thing I need is a way to shuffle both sfx and voice pools together which #2714 has but I saw your new comment on it so hopefully a more general solution is made. I mainly did this for the funny Link voice shuffle.

@garrettjoecox garrettjoecox merged commit 2da8be3 into HarbourMasters:develop Aug 20, 2023
8 checks passed
@LuigiXHero LuigiXHero deleted the silentvoiceoption branch August 20, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants