Fix more warnings. #3101
Merged
Fix more warnings. #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leggettc18
reviewed
Aug 19, 2023
| const uint32_t GetHintKey() const { | ||
| uint32_t GetHintKey() const { |
There was a problem hiding this comment.
In case anyone else didn't know because I had to look it up, const in front of a function declaration means it's returning a const reference. Since we aren't actually returning a reference here, I think the removed const keyword was doing basically nothing.
leggettc18
reviewed
Aug 19, 2023
| ImGui::Text(cosmeticOption.label.c_str()); | ||
| ImGui::Text("%s", cosmeticOption.label.c_str()); |
There was a problem hiding this comment.
Shame about this being a warning. It's just kinda making it more verbose for no real gain. Oh well.
leggettc18
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix format security warnings, Fix functions that return const, and fix a memory leak.
Build Artifacts