Fix: Dark Link's inputs in Mirror mode #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leggettc18
approved these changes
Aug 12, 2023
|
Was merge ready removed on purpose? @garrettjoecox |
I removed it from the PRs that didn’t meet the timing criteria(en mass cause I added a bunch that didn’t meet the criteria). In this case your approval makes it now meet the timing criteria (3 approvals and 3+ days since first approval) so re-adding the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dark Link's update logic runs through
Player_UpdateCommonjust like the regular player. This means Dark Link's simulated "controller" inputs were getting inverted in mirror mode. This was causing him to move irregularly while mirror mode is active.This adds another inverse to Dark Link's relative stick x input to negate the second inverse later on in
Player_UpdateCommon, fixing his "AI" behavior when mirror mode is on.Build Artifacts