Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libultraship (OpenGL window position fix) #3113

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Update libultraship (OpenGL window position fix) #3113

merged 1 commit into from
Aug 13, 2023

Conversation

Spodi
Copy link
Contributor

@Spodi Spodi commented Aug 11, 2023 •
edited by github-actions bot
Loading

  • Fixed window pos not restored with OpenGL
  • Fixed fullscreen in OpenGL (again)
    Fixes going full screen on the next monitor when the game was on the second half of the screen.
  • Set Fullscreen state only when call succeeds
    Also some logging so we hopefully know why it failed.
  • Consistent behavior for getting monitor
    SDL always gets the monitor at the middle of the window. Now DXGI does too. Also only resets the position if there is no pixel of the window on any screen.
  • also get current monitor on resize (DirectX)

Build Artifacts

briaguya-ai
briaguya-ai approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@briaguya-ai briaguya-ai mentioned this pull request Aug 11, 2023
Closed
@leggettc18 leggettc18 merged commit fafd35c into HarbourMasters:develop-sulu Aug 13, 2023
8 checks passed
@leggettc18 leggettc18 mentioned this pull request Aug 13, 2023
Merged
@Spodi Spodi deleted the bump-LUS-sulu branch October 3, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

@leggettc18 leggettc18 leggettc18 approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Spodi @garrettjoecox @leggettc18 @briaguya-ai