Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod options: Rotation options for bombs and grottos #3146

Merged

Conversation

aMannus
Copy link
Contributor

@aMannus aMannus commented Aug 23, 2023

2 checkboxes to toggle on or off some code regarding rotation for grottos and bombs so people can replace them with fully 3D models as mods and not have them rotate weirdly.

I wish I could think of a more graceful way to implement this instead of having checkboxes but I wouldn't know how. So until then, this PR exists.

Showcase of why this is needed here:
https://cdn.discordapp.com/attachments/996908955144044614/1144024170330587277/2023-08-23_23-38-12_2.mp4

Build Artifacts

@MoriyaFaith
Copy link
Contributor

Check for the existence of a custom DL name that doesn't actually exist in soh.otr, that would be used as the 3d equivalent, I guess. At least it worked for my code.

@garrettjoecox
Copy link
Contributor

Check for the existence of a custom DL name that doesn't actually exist in soh.otr, that would be used as the 3d equivalent, I guess. At least it worked for my code.

@aMannus thoughts on this? Want to try it here or merge and try separately?

@aMannus
Copy link
Contributor Author

aMannus commented Sep 10, 2023

Check for the existence of a custom DL name that doesn't actually exist in soh.otr, that would be used as the 3d equivalent, I guess. At least it worked for my code.

I'm not entirely sure what you're suggesting. Do you mean modders would instead use a "non-existing" dlist name which, if it exists, the game would render using that dlist and also disable the rotation?

@garrettjoecox garrettjoecox merged commit 8d3adb4 into HarbourMasters:develop Sep 15, 2023
8 checks passed
@aMannus aMannus deleted the remove-billboarding-mods branch September 16, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants