Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gDebugSaveFileMode #3170

Merged
merged 5 commits into from Sep 15, 2023

Conversation

Pepe20129
Copy link
Contributor

@Pepe20129 Pepe20129 commented Sep 3, 2023

Adds a new option that allows turning off debug save file creation and also allows to make a maxed save file instead of the vanilla one which has some upgrades missing.

Build Artifacts

Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this concept could be generalized to creating saves at different save points in a playthrough, for people who lose their saves and don't want to start from scratch, but doesn't have to happen now or in this PR, just a thought for future iteration

ImGui::Text("Debug Save File Mode:");
UIWidgets::EnhancementCombobox("gDebugSaveFileMode", DebugSaveFileModes, 1);
UIWidgets::Tooltip(
"Changes the behaviour of debug file select creation (creating a save file on slot 1 with debug mode on)\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: have we decided to standardize on American spellings? Genuinely asking since I'm not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we've standardized, I'm pretty sure both exist throughout the codebase

@garrettjoecox garrettjoecox merged commit 3116a9c into HarbourMasters:develop Sep 15, 2023
8 checks passed
@Pepe20129 Pepe20129 deleted the debug_save_file_mode branch January 14, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants