Add gRegEditEnabled #3173
Add gRegEditEnabled #3173
Conversation
There was a problem hiding this comment.
Looks good.
To add context, I dug into this a couple weeks ago and found that basically there is two things missing for this to have worked as intended.
- We are not setting the controller type in
padmgr.cas the "normal" type - When initializing the padmgr and the LUS controller side, LUS does some things asynchronously and overwrites a value to 0, causing the
gIsCtrlr2Validglobal to be not set. In the snippet below,outMaskis immediately set to0by LUS, and then later is updated async.Shipwright/soh/src/code/padsetup.c
Lines 7 to 12 in 644ab7f
With the addition of other ports leveraging LUS and the potential for other supported peripherals, we may want to consider updating LUS to report these things for us, like how we handled rumble support.
All that to say, I think having a dedicated CVar is totally fine here 👍 as ultimately, even if LUS was updated, the padmgr setup code is executed only once on launch, so requiring someone to re-launch with two controllers connected just for this is overkill.
| @@ -1349,6 +1349,10 @@ void DrawDeveloperToolsMenu() { | |||
| { | |||
| UIWidgets::EnhancementCheckbox("OoT Debug Mode", "gDebugEnabled"); | |||
| UIWidgets::Tooltip("Enables Debug Mode, allowing you to select maps with L + R + Z, noclip with L + D-pad Right, and open the debug menu with L on the pause screen"); | |||
| if (CVarGetInteger("gDebugEnabled", 0)) { | |||
| UIWidgets::EnhancementCheckbox("OoT Registry Editor", "gRegEditEnabled"); | |||
There was a problem hiding this comment.
Can we prefix with debug here gDebugRegEditEnabled. We are trying to categorize CVars under umbrellas, and I think it would be good to break out other debug features into similar sub-toggles.
There was a problem hiding this comment.
Would it be preferred to use gDebug.RegEditEnabled so that all the cvars we add under debug are indented together in the json?
There was a problem hiding this comment.
I think thats fine, but I'll let @Malkierian confirm since they are working on nesting our existing CVars.
There was a problem hiding this comment.
We can revisit when we get here, the cvar renames haven't been finalized yet
Adds a cvar that enables the Registry Editor.
It should always be enabled but it checks for
gIsCtrlr2Validwhich is not updated properly, it probably has been broken since the initial porting.Build Artifacts