Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix greg as reward logic #3297

Merged
merged 1 commit into from Oct 19, 2023
Merged

Fix greg as reward logic #3297

merged 1 commit into from Oct 19, 2023

Conversation

inspectredc
Copy link
Contributor

@inspectredc inspectredc commented Oct 16, 2023 •
edited by github-actions bot

Initially the reward logic would internally be set to 'greg as reward' for both the bridge and lacs rewards only if at least 1 had that option selected. This lead to scenarios where the bridge rewards would be set to standard, and the lacs rewards would be set to greg as reward, which caused the bridge logic to require greg

Build Artifacts

briaguya-ai
briaguya-ai approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@garrettjoecox garrettjoecox merged commit c3784b9 into HarbourMasters:develop Oct 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

@Archez Archez Archez approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@inspectredc @garrettjoecox @Archez @briaguya-ai