Fix: Entrance Rando validation missing edge cases #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
approved these changes
Nov 2, 2023
briaguya-ai
approved these changes
Nov 4, 2023
aMannus
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Entrance Rando, validation is performed on special entrance conditions like Temple of Time, when some entrances are placed. But later in the shuffling process, more entrances are placed without the same validation performed. This could lead to a situation where Temple of Time is no longer accessible after shuffled spawns.
To address this, we validate the world one more time after all entrances are done being shuffled. This matches roughly what N64 does, and pulls in a recent fix from 3ds rando.
Build Artifacts