Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio cutoff issues #3428

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Nov 22, 2023

The result of osAiSetFrequency was being used later on to multiply the length an audio sequence would play. In debug mode this stub was returning 1, whereas in release mode this would return whatever was passed in as the freq argument.

Build Artifacts

Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STUUUUUUUBS

@Archez Archez linked an issue Nov 22, 2023 that may be closed by this pull request
@briaguya-ai briaguya-ai merged commit bdb2012 into HarbourMasters:develop-macready Nov 24, 2023
8 checks passed
A-Green-Spoon pushed a commit to A-Green-Spoon/Shipwright that referenced this pull request Nov 30, 2023
@garrettjoecox garrettjoecox deleted the fix-audio-cut-issues branch March 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio cut-off on long voice clip
3 participants