[Rando] Fix Check Tracker Area Totals #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onality setting invisible checks. Change `areaChecksTotal` to dynamic calculation based on tracker visibility, now that all checks are being added to `checksByArea`. Both are updated in realtime when either "Show all GS locations" or "Hide right side shop items" are toggled. Reformat all remaining unencapsulated if statements.
|
https://github.com/HarbourMasters/Shipwright/assets/774771/8b6a62a3-430b-466c-9e93-d3562f5b42e6 |
briaguya-ai
reviewed
Dec 29, 2023
…to when the options are toggled instead of checking every frame. Removed redundant if...else. Clarified areaChecksGotten increment/decrement functionality based on current status and incoming status change.
briaguya-ai
reviewed
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changing to the flags tracking system for the check tracker, it would show incorrect totals for checks gotten because invisible checks were getting set and adding to the count for that. Also, when adding "Always show gold skulltulas" option, the total checks shown in an area was wrong because all checks were being added to
checksByAreaall the time instead of only those visible. This fixes both, and both update in real time when "Always show gold skulltulas" or "Hide right-side shop item checks" are toggled.Also reformats some of the code of
randomizer_check_tracker.cppto eliminate all remaining instances of unencapsulated if statements.soh_5ekteFl4Yh.mp4
Build Artifacts