Fix Starting Triforce Piece Count #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izer_InitSaveFile()` to fix starting TFP count issues.
Archez
approved these changes
Jan 4, 2024
briaguya-ai
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out,
triforcePiecesCollectedwas getting zeroed at the end ofRandomizer_InitSaveFile(), which was undoing any counting being done for starting triforce pieces, thus preventing triforce hunt completion when starting with any pieces and requiring the exact number as in the pool. This moves that to the start ofRandomizer_InitSaveFile()instead.Build Artifacts