Fix: Timestamp truncation #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspectredc
approved these changes
Jan 23, 2024
leggettc18
approved these changes
Jan 23, 2024
|
The CI is failing because it can't download SDL, not sure what's going on there exactly. |
|
Third times the charm! |
garrettjoecox
approved these changes
Feb 2, 2024
garrettjoecox
merged commit 7ef6a43
into
HarbourMasters:develop-macready
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our timestamp function using chrono was downcasting a
long longto alongbefore finally casting it up touint64_t(which isunsigned long long). This was causing the timestamp values to be truncated to 32 bits. Visually the in-game timers still displayed "ok" since it was comparing truncated value against truncated.This change removes the down cast to prevent the truncation. After this merge, any save created before that was using RTA timing will display a large difference, but that in my opinion is not a big deal because most people aren't playing RTA timing across updates/many days apart from creation.
Build Artifacts