Increase Door Cull range #3888
Merged
Increase Door Cull range #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettjoecox
approved these changes
Feb 2, 2024
garrettjoecox
merged commit 2529dc5
into
HarbourMasters:develop-macready
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #3828 my suspicion is that the uncullzone scale check was changed due to issues with widescreen and doors. They are quite noticeably culled which ends up looking very off. I wasn't sure on the best approach, i.e. should this be default/ limited to doors/ what actors should be under this. So I am just putting this up with what I think makes sense, i.e. defaulting to increased uncull zones for doors, and using a hidden cvar
Build Artifacts